Merge pull request mloughran#11 from pusher/master

Deal gracefully with nil parameters in comparison
YourAcclaim · Mar 6, 2015 · 50b18ef · 50b18ef
2 parents a1fe7d5 + 3d9a0bd
commit 50b18ef
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/lib/signature.rb b/lib/signature.rb
@@ -223,6 +223,8 @@ def validate_signature!(token)
 
       # Constant time string comparison
       def identical?(a, b)
+        return true if a.nil? && b.nil?
+        return false if a.nil? || b.nil?
         return false unless a.bytesize == b.bytesize
         a.bytes.zip(b.bytes).reduce(0) { |memo, (a, b)| memo += a ^ b } == 0
       end