Fixed regression handling queries with nil values

YourAcclaim · Apr 22, 2013 · 38d8118 · 38d8118
1 parent 7efcdca
commit 38d8118
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/signature/query_encoder.rb b/lib/signature/query_encoder.rb
@@ -17,7 +17,7 @@ def encode_param_without_escaping(k, v)
         if v.is_a?(Array)
           v.map { |e| k + "[]=" + e }.join("&")
         else
-          k + "=" + v
+          "#{k}=#{v}"
         end
       end
 

diff --git a/spec/signature_spec.rb b/spec/signature_spec.rb
@@ -75,6 +75,13 @@
       @request.send(:string_to_sign).should == "POST\n/some/path\nkey;=value@"
     end
 
+    it "should cope with requests where the value is nil (antiregression)" do
+      @request.query_hash = {
+        "key" => nil
+      }
+      @request.send(:string_to_sign).should == "POST\n/some/path\nkey="
+    end
+
     it "should use the path to generate signature" do
       @request.path = '/some/other/path'
       @request.sign(@token)[:auth_signature].should_not == @signature