Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WOR-4059] - Upgrade to ruby 3.2.3 #1

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

weslleyalmd
Copy link

@weslleyalmd weslleyalmd commented Feb 12, 2024

@weslleyalmd weslleyalmd requested a review from dleeman February 12, 2024 17:24
@weslleyalmd weslleyalmd self-assigned this Feb 12, 2024
Copy link

@AMathews AMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Thanks for the test run confirmation!

@@ -23,7 +23,7 @@ Gem::Specification.new do |gem|
gem.add_dependency 'sass-rails', '>= 3.2.5'
gem.add_dependency 'jquery-fileupload-rails', '~> 0.4.1'

gem.add_development_dependency 'bundler', '~> 1.3'
gem.add_development_dependency 'bundler', '~> 2.5.6'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: It doesn't really matter here but we, at least for the moment probably want to standardize around the version of bundler that Heroku provides, 2.3.25. So saying >= 2.3.25 makes sense to me. But this really is a nitpick since it won't really matter in actuality.

@weslleyalmd weslleyalmd marked this pull request as draft February 27, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants