Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API domain [IN-985] #48

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Update API domain [IN-985] #48

merged 2 commits into from
Mar 20, 2023

Conversation

Hobogrammer
Copy link
Contributor

@Hobogrammer Hobogrammer commented Mar 16, 2023 •
edited
Loading

IN-985

Change API endpoint to 'api.credly.com' from 'api.youracclaim.com'

@Hobogrammer
Update API domain [IN-985]
bbc553d 
- Change API endpoint to 'api.credly.com' from 'api.youracclaim.com'
@Hobogrammer
Update API domain [IN-985]
050e373 
- Update version
@Hobogrammer Hobogrammer self-assigned this Mar 16, 2023
@Hobogrammer Hobogrammer marked this pull request as ready for review March 16, 2023 23:51
@Hobogrammer Hobogrammer requested review from tylersp7 and dleeman March 16, 2023 23:51
tylersp7
tylersp7 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@tylersp7 tylersp7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API updates look good, I also created a plugin from the branch and uploaded it to our test moodle instance and confirmed I was able to trigger badges and received them from it, so it's good to go! Thank you for the updates! 🙏 :shipit:

dleeman
dleeman approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@dleeman dleeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks fine to me. Thanks for making these long-overdue updates!

@Hobogrammer Hobogrammer merged commit 53fe53f into master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dleeman dleeman dleeman approved these changes

@tylersp7 tylersp7 tylersp7 approved these changes

Assignees

@Hobogrammer Hobogrammer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hobogrammer @tylersp7 @dleeman