icepll enhancements #303
Open
icepll enhancements #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support PHASE_AND_DELAY + SHIFTREG feedback, which uses a 4x VCO multiplier behind the scenes - allow overriding clock constraints, just in case you like to live on the edge
lethalbit
reviewed
Oct 2, 2022
| FEEDBACK_PHASE_AND_DELAY, | ||
| }; | ||
|
|
||
| struct freq_constraint { |
There was a problem hiding this comment.
consider using a std::pair<double, double> rather than defining a custom struct for this,
lethalbit
reviewed
Oct 2, 2022
| @@ -25,6 +25,20 @@ | |||
| #include <emscripten.h> | |||
| #endif | |||
|
|
|||
| enum feedback_mode | |||
There was a problem hiding this comment.
This should probably be an enum struct so the enum values are properly scoped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support PHASE_AND_DELAY + SHIFTREG feedback, which uses a 4x VCO multiplier behind the scenes
allow overriding clock constraints, just in case you like to live on the edge. my testing suggests that the 10 MHz F_pfd minimum is highly flexible, for example