Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model best state #887

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Model best state #887

merged 2 commits into from
Jan 21, 2021

Conversation

adamgayoso
Copy link
Member

we used to save the best state of the model before pytorch lit rebasing. Here's a simple callback that does just this.

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #887 (156287a) into master (32e12bb) will decrease coverage by 0.14%.
The diff coverage is 72.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
- Coverage   89.46%   89.31%   -0.15%     
==========================================
  Files          70       70              
  Lines        5296     5344      +48     
==========================================
+ Hits         4738     4773      +35     
- Misses        558      571      +13     
Impacted Files Coverage Δ
scvi/lightning/_callbacks.py 76.36% <72.91%> (-23.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e12bb...156287a. Read the comment docs.

@adamgayoso adamgayoso merged commit c807316 into master Jan 21, 2021
@adamgayoso adamgayoso deleted the model_best_state branch January 21, 2021 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant