Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Compact array after readdirsync #8

Merged
merged 1 commit into from
Sep 11, 2017

Conversation

wenderjean
Copy link
Contributor

@wenderjean wenderjean commented Sep 7, 2017

Related to #5

When trying to invoke update function the error below was showed to me:

Cannot match against 'undefined' or 'null'.

The problem was happening on destructuring present in line 87, after debugging I found out that the array of functions had an undefined item because inside the function's I had a .DS_Store file.

[undefined, { ... }, { ... }]

My proposal is to filter results right away after readdsync map instruction.

@YoruNoHikage YoruNoHikage merged commit 21a2c38 into YoruNoHikage:master Sep 11, 2017
@YoruNoHikage
Copy link
Owner

Thanks, quick and tiny solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants