Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n: various fixes #59

Merged
merged 4 commits into from
Mar 27, 2018
Merged

I18n: various fixes #59

merged 4 commits into from
Mar 27, 2018

Commits on Mar 15, 2018

  1. I18n: fix incorrect text-domain

    The text-domain for WordPress itself is `default`, not `wordpress`.
    jrfnl committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    fe33973 View commit details
    Browse the repository at this point in the history
  2. I18n: add missing translators comments

    Includes minor efficiency fix for `sprintf()`: when using numbered replacements, you can use the same replacement twice, so no need to have `'</a>'` twice in the replacement list.
    jrfnl committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    92c1336 View commit details
    Browse the repository at this point in the history
  3. I18n: Make the text slightly more plugin agnostic

    AFAIK WHIP is intended to also be usable by other (non-Yoast) plugins/themes.
    There were currently two phrases which made this awkward.
    
    This PR changes those.
    
    For the first phrase, I've chosen to change `WordPress and Yoast SEO` to `WordPress and all it's plugins and themes`. This incidentally fixes issue 35.
    If it is preferred that `Yoast SEO` not be removed, I would suggest the following:
    * Move the name out of the text string and put it back in using `sprintf()`.
    * Make the name filterable to allow other plugins to pass in their plugin name.
        - Potentially, it could even be turned into an array which could be passed into the string using `implode()` to allow for a number of plugins to be mentioned.
    
    For the second phrase, just changing the `our` in `vetted by our Yoast support team` to `the` improves the re-usability.
    
    Fixes 35
    jrfnl committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    cfaa0f7 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2018

  1. Change typo

    Joost de Valk authored Mar 27, 2018
    Configuration menu
    Copy the full SHA
    2950138 View commit details
    Browse the repository at this point in the history