Whip_RequirementsChecker: explicitly declare all properties #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamic (non-explicitly declared) property usage is expected to be deprecated as of PHP 8.2 and will become a fatal error in PHP 9.0. There are a number of ways to mitigate this: * If it's an accidental typo for a declared property: fix the typo. * For known properties: declare them on the class. * For unknown properties: add the magic `__get()`, `__set()` et al methods to the class or let the class extend `stdClass` which has highly optimized versions of these magic methods build in. * For unknown _use of_ dynamic properties, the `#[AllowDynamicProperties]` attribute can be added to the class. The attribute will automatically be inherited by child classes. In this case, both the `$configuration` property, as well as the `$messageManager` property fall in the "known property" category and should be declared. Note: while this _could_ be considered a BC-break, I've elected to make these properties `private` (was previously automatically `public` due to these being dynamic properties). Refs: * https://wiki.php.net/rfc/deprecate_dynamic_properties
jrfnl
force-pushed
the
JRF/php-8.2/handle-dynamic-property
branch
from
ce5ba97
to
df5ab81
Compare
|
@diedexx As you are working on something to do with WHIP, want to take a look at this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic (non-explicitly declared) property usage is expected to be deprecated as of PHP 8.2 and will become a fatal error in PHP 9.0.
There are a number of ways to mitigate this:
__get(),__set()et al methods to the class or let the class extendstdClasswhich has highly optimized versions of these magic methods build in.#[AllowDynamicProperties]attribute can be added to the class. The attribute will automatically be inherited by child classes.In this case, both the
$configurationproperty, as well as the$messageManagerproperty (both set in the class constructor) fall in the "known property" category and should be declared.Note: while this could be considered a BC-break, I've elected to make these properties
private(was previously automaticallypublicdue to these being dynamic properties).Refs: