PHPUnit 11.2.0 | AssertObjectNotEquals trait: polyfill the Assert::assertObjectNotEquals() method #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
changed the title
…lidator` helper class ... as the same logic is needed for the (upcoming) PHPUnit 11.2+ `AssertObjectNotEquals` trait.
…sertObjectNotEquals() method
PHPUnit 11.2.0 introduced the new `Assert::assertObjectNotEquals()` method.
This commit:
* Adds two traits with the same name.
One to polyfill the method when not available in PHPUnit.
The other to allow for `use`-ing the trait in PHPUnit versions in which the method is already natively available.
* Logic to the custom autoloader which will load the correct trait depending on the PHPUnit version used.
* Adds tests.
As the polyfill contains logic to match the PHPUnit native implementation as closely as possible, while still being PHP and PHPUnit cross-version compatible, extensive unit tests have been added to ensure the behaviour of the polyfill matches that of the original function.
Includes:
* Adding information on the new polyfill to the README.
* Adding the new polyfill to the existing `TestCases` classes.
* Updating the class docs for the `InvalidComparisonMethodException` and the `ComparatorValidator` classes.
Refs:
* sebastianbergmann/phpunit#5811
* sebastianbergmann/phpunit@8e3b7c1
Co-authored-by: Sebastian Bergmann <[email protected]>
jrfnl
force-pushed
the
feature/3.x/new-assertobjectnotequals-polyfill-trait
branch
from
a3622b2
to
35688cc
Compare
hellofromtonya
deleted the
feature/3.x/new-assertobjectnotequals-polyfill-trait
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AssertObjectEquals: move comparator validation logic to
ComparatorValidatorhelper class... as the same logic is needed for the (upcoming) PHPUnit 11.2+
AssertObjectNotEqualstrait.PHPUnit 11.2.0 | AssertObjectNotEquals trait: polyfill the Assert::assertObjectNotEquals() method
PHPUnit 11.2.0 introduced the new
Assert::assertObjectNotEquals()method.This commit:
One to polyfill the method when not available in PHPUnit.
The other to allow for
use-ing the trait in PHPUnit versions in which the method is already natively available.As the polyfill contains logic to match the PHPUnit native implementation as closely as possible, while still being PHP and PHPUnit cross-version compatible, extensive unit tests have been added to ensure the behaviour of the polyfill matches that of the original function.
Includes:
TestCasesclasses.InvalidComparisonMethodExceptionand theComparatorValidatorclasses.Refs:
assertObjectNotEquals()sebastianbergmann/phpunit#5811