Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for the AssertAttributeHelper #194

Merged

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Sep 6, 2024

This "helper" was only intended as a temporary measure to buy people some more time to refactor their tests.

This "helper" was only intended as a temporary measure to buy people some more time to refactor their tests.
@coveralls
Copy link

Coverage Status

coverage: 97.104% (-0.04%) from 97.143%
when pulling f4f22b6 on feature/3.x/drop-support-for-assertattributehelper
into 60b6f02 on 3.x.

Copy link
Collaborator

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to drop this support. This interim helper has been there for 2 majors. By now, projects should have refactored. LGTM 👍

@hellofromtonya hellofromtonya merged commit f0cd55e into 3.x Sep 6, 2024
144 checks passed
@hellofromtonya hellofromtonya deleted the feature/3.x/drop-support-for-assertattributehelper branch September 6, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants