Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect visibility of fixture overload methods when using XTestCase in the documentation #10

Closed
MarkBaker opened this issue Dec 21, 2020 · 0 comments · Fixed by #20
Closed

Incorrect visibility of fixture overload methods when using XTestCase in the documentation #10

MarkBaker opened this issue Dec 21, 2020 · 0 comments · Fixed by #20
Labels
Type: bug
Milestone
1.0.0

Comments

@MarkBaker
Copy link

When using the method names setUpFixturesBeforeClass(), setUpFixtures(), tearDownFixtures() and tearDownFixturesAfterClass() for fixture overloads with XTestCase, then visibility must be public to match the parent method signatures. The examples in the README file show protected visibility for setUpFixtures() and tearDownFixtures().
@MarkBaker MarkBaker mentioned this issue Dec 21, 2020
Closed
@jrfnl jrfnl added this to the 0.x Next Release milestone Jun 6, 2021
@jrfnl jrfnl added the Type: bug label Jun 6, 2021
jrfnl added a commit that referenced this issue Jun 6, 2021
@jrfnl
XTestCase: set to lowest possible visibility
2d48948 
This aligns the visibility of the methods in the `XTestCase` class with the minimum acceptable visibility to allow the methods to work.
This also ensures that the visibility used in the class now matches that of the code sample in the README.

| Native method name     | Annotation     | Minimum visibility |
|------------------------|----------------|--------------------|
| `setUpBeforeClass()`   | `@beforeClass` | `public`           |
| `setUp()`              | `@before`      | `protected`        |
| `tearDown()`           | `@after`       | `protected`        |
| `tearDownAfterClass()` | `@afterClass`  | `public`           |

Fixes #10
@jrfnl jrfnl mentioned this issue Jun 6, 2021
Merged
@jrfnl jrfnl closed this as completed in #20 Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: bug
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

XTestCase: set to lowest possible visibility Yoast/PHPUnit-Polyfills
2 participants
@jrfnl @MarkBaker