Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package to moden Julia Project.toml format #8

Merged
merged 1 commit into from
May 19, 2023
Merged

Update package to moden Julia Project.toml format #8

merged 1 commit into from
May 19, 2023

Conversation

staticfloat
Copy link
Contributor

No description provided.

@staticfloat
Copy link
Contributor Author

@YingboMa

YingboMa
YingboMa reviewed May 19, 2023
View reviewed changes
Manifest.toml Outdated
@@ -0,0 +1,7 @@
# This file is machine-generated - editing it directly is not advised

julia_version = "1.10.0-DEV"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need Manifest.toml here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there's no real need for it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove it?

@staticfloat staticfloat force-pushed the sf/modern_project_toml branch from eafe9a1 to ab306b0 Compare May 19, 2023 23:20
@YingboMa YingboMa merged commit 667b675 into YingboMa:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YingboMa YingboMa YingboMa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staticfloat @YingboMa