resolve std::numeric_limits::max() windef.h:max(a, b) conflict in atArray implementations #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yimura
approved these changes
Jan 30, 2024
Mr-X-GTA
pushed a commit
to Mr-X-GTA/GTAV-Classes-1
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a conflict in the atArray function implementations between std::numeric_limits::max() and the macro max(a, b) defined in windef.h (if NOMINMAX isnt present, see microsoft/cppwinrt#479). By wrapping std::numeric_limits::max in parenthesis before calling it, the compiler explicitly uses the intended std::numeric_limits::max() function. In the c++/winrt issue it appears like this has been fixed, but even with a fully updated v143 toolset this issue persists.