Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ClearCrimes.cpp #82

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Update ClearCrimes.cpp #82

merged 5 commits into from
Mar 21, 2024

Conversation

Deadlineem
Copy link
Contributor

@Deadlineem Deadlineem commented Mar 17, 2024

Test - working on bounty/crime removal, found some natives that could possibly fix this, i just cant figure out how to compile this sooo

This may also be of use

PLAYER::CLEAR_PLAYER_WANTED_LEVEL(guid);

Test - working on bounty/crime removal/
@Rxann
Copy link
Contributor

Rxann commented Mar 17, 2024

Do you have cmake and msvc installed on ur pc? also you should probably make this a draft pr

@Deadlineem
Copy link
Contributor Author

Deadlineem commented Mar 17, 2024

Do you have cmake and msvc installed on ur pc? also you should probably make this a draft pr

I installed vs22 + cmake + msvc extension
the issue im having is when i try to compile, it errors with 2 messages.

Screenshot_10

Screenshot_11

@Yimura
Copy link
Member

Yimura commented Mar 19, 2024

@Deadlineem do you have git installed on your PC? That might be the issue with your project not setting up properly.

@Deadlineem
Copy link
Contributor Author

@Deadlineem do you have git installed on your PC? That might be the issue with your project not setting up properly.

No but i will install git when i get home from work and get back to you on this asap @Yimura.

@Deadlineem
Copy link
Contributor Author

Deadlineem commented Mar 20, 2024

@Deadlineem do you have git installed on your PC? That might be the issue with your project not setting up properly.

I got it to compile, but the game had a small update and now it crashes :(

-- Updated the pointers on mine and its working again. Now i can finally build/test these on my own. I had to reinstall visual studio based off of yims docs.

@Deadlineem
Copy link
Contributor Author

Deadlineem commented Mar 20, 2024

Do you have cmake and msvc installed on ur pc? also you should probably make this a draft pr

BOUNTY::_BOUNTY_REQUEST_PAY_OFF_BOUNTY(guid); -- Pays the bounty price from your wallet, fairly legit // Does not remove currently active police

PLAYER::SET_WANTED_LEVEL_MULTIPLIER(0.0); 0 disables the wanted level system, 1 is default.

Changed this to Pay Bounties and reflected the code to pay off all bounties for the player.
Added "Never Wanted" toggle, instantly and effectively removes and disables your wanted level (does not pay bounties)
Added "Never Wanted" toggle to self submenu
@Deadlineem
Copy link
Contributor Author

Deadlineem commented Mar 20, 2024

@Yimura @Rxann

Updated this severely, first crack at something in C++ by myself, the commit now changes ClearCrimes.cpp to pay off bounties from your wallet balance (instead of doing nothing like before)

Adds NeverWanted.cpp which sets the wanted mode to 0 or 1 (disabled/enabled)

Adds the Never Wanted toggle to the Self tab.

All tested/working see screenshot
Screenshot_15

@tyackman
Copy link
Contributor

tyackman commented Mar 21, 2024

_BOUNTY_REQUEST_SERVED_FULL_JAIL_SENTENCE seemed to work fine, why change it? It removes your bounty for the current region you're in, unless this was changed in this last update. Have you tried _BOUNTY_REQUEST_SELF_REPORT_KILLED_BY_BOUNTY_HUNTER or _SET_BOUNTY_HUNTER_PURSUIT_CLEARED?

@Deadlineem
Copy link
Contributor Author

_BOUNTY_REQUEST_SERVED_FULL_JAIL_SENTENCE seemed to work fine, why change it? It removes your bounty for the current region you're in, unless this was changed in this last update. Have you tried _BOUNTY_REQUEST_SELF_REPORT_KILLED_BY_BOUNTY_HUNTER or _SET_BOUNTY_HUNTER_PURSUIT_CLEARED?

I used it right before the recent update, it didnt seem to work at all for me. However, having pay bounties is a more "legit" way of doing it, and also having "Never Wanted" helps alot.

Copy link

Download the artifacts for this pull request:

@Yimura Yimura merged commit ced81a6 into YimMenu:master Mar 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants