Protection and made various code improvements.

CMakeLists.txt

@@ -18,6 +18,8 @@ file(GLOB_RECURSE SRC_FILES
     "${SRC_DIR}/**.cpp"
 )
 set(DEPS_DIR "${PROJECT_SOURCE_DIR}/deps")
+#compile faster
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /MP")
 
 add_library(${PROJECT_NAME} MODULE ${SRC_FILES})
 set_property(TARGET ${PROJECT_NAME} PROPERTY CXX_STANDARD 23)

src/core/frontend/manager/Category.cpp

@@ -13,7 +13,7 @@ namespace YimMenu
 		if (m_Length.has_value())
 			return m_Length.value();
 
-		m_Length = std::max(ImGui::CalcTextSize(m_Name.c_str()).x + 25.0f, 75.0f);
+		m_Length = static_cast<int>(std::max(ImGui::CalcTextSize(m_Name.c_str()).x + 25.0f, 75.0f));
 		return m_Length.value();
 	}
 }

src/core/hooking/Hooking.cpp

@@ -42,6 +42,7 @@ namespace YimMenu
 		BaseHook::Add<Hooks::Protections::HandleCloneCreate>(new DetourHook("HandleCloneCreate", Pointers.HandleCloneCreate, Hooks::Protections::HandleCloneCreate));
 		BaseHook::Add<Hooks::Protections::HandleCloneSync>(new DetourHook("HandleCloneSync", Pointers.HandleCloneSync, Hooks::Protections::HandleCloneSync));
 		BaseHook::Add<Hooks::Protections::CanApplyData>(new DetourHook("CanApplyData", Pointers.CanApplyData, Hooks::Protections::CanApplyData));
+		BaseHook::Add<Hooks::Protections::PhysicCrash>(new DetourHook("PhysicCrash", Pointers.PhysicCrash, Hooks::Protections::PhysicCrash));
 		BaseHook::Add<Hooks::Protections::ResetSyncNodes>(new DetourHook("ResetSyncNodes", Pointers.ResetSyncNodes, Hooks::Protections::ResetSyncNodes));
 		BaseHook::Add<Hooks::Protections::HandleScriptedGameEvent>(new DetourHook("HandleScriptedGameEvent", Pointers.HandleScriptedGameEvent, Hooks::Protections::HandleScriptedGameEvent));
 		BaseHook::Add<Hooks::Protections::AddObjectToCreationQueue>(new DetourHook("AddObjectToCreationQueue", Pointers.AddObjectToCreationQueue, Hooks::Protections::AddObjectToCreationQueue));

src/game/frontend/items/ListCommandItem.cpp

@@ -46,7 +46,7 @@ namespace YimMenu
 				m_SelectedItem = "";
 
 			auto size = ImGui::CalcTextSize(largest_string);
-			m_ItemWidth = size.x + 25.0f;
+			m_ItemWidth = static_cast<int>(size.x + 25.0f);
 		}
 
 		ImGui::SetNextItemWidth(m_ItemWidth.value());

src/game/frontend/submenus/Network.cpp

@@ -209,7 +209,12 @@ namespace YimMenu::Submenus
 		static const char* iconBuf = "";
 		infoSpoofingGroup->AddItem(std::make_shared<ImGuiItem>([=] {
 			static std::map<std::string, std::string> colors = {{"", "None"}, {"~e~", "Red"}, {"~f~", "Off White"}, {"~p~", "White"}, {"~o~", "Yellow"}, {"~q~", "Pure White"}, {"~d~", "Orange"}, {"~m~", "Light Grey"}, {"~t~", "Grey"}, {"~v~", "Black"}, {"~pa~", "Blue"}, {"~t1~", "Purple"}, {"~t2~", "Orange"}, {"~t3~", "Teal"}, {"~t4~", "Light Yellow"}, {"~t5~", "Pink"}, {"~t6~", "Green"}, {"~t7~", "Dark Blue"}};
+
+			#pragma warning(push)
+			#pragma warning(disable : 4566)
 			static std::map<const char*, std::string> icons = {{"", "None"}, {"∑", "Rockstar Icon"}};
+			#pragma warning(pop)
+
 			ImGui::Text("Spoofed data will not appear locally, and will only be visible when joining a new session,\n or when a player joins you");
 
 			ImGui::Text("Name");

src/game/hooks/Hooks.hpp

@@ -99,6 +99,7 @@ namespace YimMenu::Hooks
 		extern bool ReceiveArrayUpdate(void* array, CNetGamePlayer* sender, rage::datBitBuffer* buffer, int size, int16_t cycle);
 		extern void* CreatePoolItem(PoolUtils<Entity>* pool);
 		extern int HandleCloneRemove(void* mgr, CNetGamePlayer* sender, CNetGamePlayer* target, uint16_t objectId, int ownershipToken, bool unk);
+		extern __int64 PhysicCrash(__int64 a1, unsigned int a2, int* a3); // Don't really know what to call it. Lets go with PhysicCrash
 	}
 
 	namespace Voice

src/game/hooks/Protections/PhysicCrash.cpp

@@ -0,0 +1,27 @@
+#include "core/hooking/DetourHook.hpp"
+#include "game/hooks/Hooks.hpp"
+#include "game/pointers/Pointers.hpp"
+#include "game/backend/Protections.hpp"
+
+
+namespace YimMenu::Hooks
+{
+	// This not only prevents certain crashes but also helps block lag from some objects. Maybe we should call it LodCrash
+	__int64 Protections::PhysicCrash(__int64 a1, unsigned int a2, int* a3)
+	{
+		unsigned int v11; // esi
+		__int64 v9;       // rbx
+
+		v9 = *(unsigned long long*)(a1 + 40) + 80i64 * a2;
+		if (v9)
+		{
+			v11 = *(unsigned __int16*)(v9 + 72);
+			if (v11 > 1000) 
+			{
+				return 0;
+			}
+		}
+
+		return BaseHook::Get<Protections::PhysicCrash, DetourHook<decltype(&Protections::PhysicCrash)>>()->Original()(a1, a2, a3);
+	}
+}

src/game/hooks/Protections/ShouldBlockSync.cpp

@@ -166,8 +166,8 @@ namespace
 			break;
 		}
 	}
-
-	static const std::unordered_set<uint32_t> g_CrashObjects = {0xD1641E60, 0x6927D266};
+	/* {mp_a_c_elk_01} model does not crash & our new hook already avoids crash from {s_chuckwagonawning01b} but lets keep it for notifications.*/
+	static const std::unordered_set<uint32_t> g_CrashObjects = {"s_chuckwagonawning01b"_J};
 	static const std::unordered_set<uint32_t> g_FishModels   = {
         "A_C_Crawfish_01"_J,
         "A_C_FishBluegil_01_ms"_J,
@@ -284,13 +284,7 @@ namespace
 		{
 		case "CPedCreationNode"_J:
 		{
-			// this is a really bad protection, but it works
 			auto& data = node->GetData<CPedCreationData>();
-			if (data.m_ModelHash == "CS_MP_BOUNTYHUNTER"_J)
-			{
-				SyncCrashBlocked("unknown ped crash");
-				return true;
-			}
 
 			if (data.m_ModelHash && !STREAMING::IS_MODEL_A_PED(data.m_ModelHash))
 			{

src/game/pointers/Pointers.cpp

@@ -458,6 +458,11 @@ namespace YimMenu
 			PackCloneCreate = ptr.Sub(0x34).As<PVOID>();
 		});
 
+		constexpr auto physicCrashPtrn = Pattern<"48 8B C4 48 89 58 08 48 89 70 10 48 89 78 18 4C 89 70 20 55 48 8D 68 E8 48 81 EC ? ? ? ? 0F 28 1D ? ? ? ? 0F 57 D2">("PhysicCrash");
+		scanner.Add(physicCrashPtrn, [this](PointerCalculator ptr) {
+			PhysicCrash = ptr.As<PVOID>();
+		});
+
 		if (!scanner.Scan())
 		{
 			LOG(FATAL) << "Some patterns could not be found, unloading.";

src/game/pointers/Pointers.hpp

@@ -146,6 +146,7 @@ namespace YimMenu
 		PVOID ReceiveArrayUpdate;
 
 		PVOID CreatePoolItem;
+		PVOID PhysicCrash;
 
 
 		// Player Stuff