Skip to content

Conversation

@Yikun
Copy link
Owner

@Yikun Yikun commented Dec 9, 2022

What changes were proposed in this pull request?

According to https://pandas.pydata.org/docs/reference/api/pandas.io.formats.style.Styler.to_latex.html:
pandas.io.formats.style.Styler.to_latex introduced since 1.3.0, so before panda 1.3.0, should skip the check

ERROR [0.180s]: test_style (pyspark.pandas.tests.test_dataframe.DataFrameTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/__w/spark/spark/python/pyspark/pandas/tests/test_dataframe.py", line 5795, in test_style
    check_style()
  File "/__w/spark/spark/python/pyspark/pandas/tests/test_dataframe.py", line 5793, in check_style
    self.assert_eq(pdf_style.to_latex(), psdf_style.to_latex())
AttributeError: 'Styler' object has no attribute 'to_latex'

Related: apache@58375a8

Why are the changes needed?

This test break the 3.2 branch pyspark test (with python 3.6 + pandas 1.1.x), so I think better add the skipIf it.

See also apache#38982 (comment)

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • CI passed

@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Mar 20, 2023
@github-actions github-actions bot closed this Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants