Test infra change #170
Closed
Test infra change #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
pushed a commit
to apache/spark
that referenced
this pull request
Sep 13, 2022
… dockerfile is changed ### What changes were proposed in this pull request? Do base image real in time build only when infra dockerfile is changed. ### Why are the changes needed? Recently github ghcr is [unstable](https://github.com/orgs/community/discussions/32184), so we better use infra static image when no infra dockerfile changes. After this change even github ghcr image write has some issue, only infra dockerfile PR is blocked, other PR don't have any impact. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? 1. CI passed, and [use](https://github.com/Yikun/spark/runs/8242449708?check_suite_focus=true#step:2:19) the `ghcr.io/apache/spark/apache-spark-github-action-image-cache:master-static`. 2. local test infra changes trigger CI: Yikun#170 3. test `./dev/is-changed.py -m infra-image`  ``` # previous hash of dockerfile is changed $ export APACHE_SPARK_REF=871152bda69a5d5db714eecd42fdd3e7d2e04557 $ ./dev/is-changed.py -m infra-image true # hash of dockerfile is changed $ export APACHE_SPARK_REF=0830575100c1bcbc89d98a6859fe3b8d46ca2e6e $ ./dev/is-changed.py -m infra-image false # next hash of dockerfile is changed $ export APACHE_SPARK_REF=e6c58c1bd6f64ebfb337348fa6132c0b230dc932 $ ./dev/is-changed.py -m infra-image false ``` Closes #37828 from Yikun/infra-image-static. Authored-by: Yikun Jiang <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Yikun
added a commit
that referenced
this pull request
Oct 6, 2022
… dockerfile is changed ### What changes were proposed in this pull request? Do base image real in time build only when infra dockerfile is changed. ### Why are the changes needed? Recently github ghcr is [unstable](https://github.com/orgs/community/discussions/32184), so we better use infra static image when no infra dockerfile changes. After this change even github ghcr image write has some issue, only infra dockerfile PR is blocked, other PR don't have any impact. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? 1. CI passed, and [use](https://github.com/Yikun/spark/runs/8242449708?check_suite_focus=true#step:2:19) the `ghcr.io/apache/spark/apache-spark-github-action-image-cache:master-static`. 2. local test infra changes trigger CI: #170 3. test `./dev/is-changed.py -m infra-image`  ``` # previous hash of dockerfile is changed $ export APACHE_SPARK_REF=871152bda69a5d5db714eecd42fdd3e7d2e04557 $ ./dev/is-changed.py -m infra-image true # hash of dockerfile is changed $ export APACHE_SPARK_REF=0830575100c1bcbc89d98a6859fe3b8d46ca2e6e $ ./dev/is-changed.py -m infra-image false # next hash of dockerfile is changed $ export APACHE_SPARK_REF=e6c58c1bd6f64ebfb337348fa6132c0b230dc932 $ ./dev/is-changed.py -m infra-image false ``` Closes apache#37828 from Yikun/infra-image-static. Authored-by: Yikun Jiang <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?