-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for JSON response capture #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you are looking to do is get the raw answer from the google api? As it stands locationObject does not contain the google response, but a reworked object (based on withValues).
I would have thought of adding a template variable {{response}} which like the others would simply add the raw google response.
I don't actually want the raw response, but the retrieved address (based on the values passed) so this is fine. It could be an addition to add support for the raw response, but at that point we'd probably need support to ignore some keys, I'm not sure. I guess if you want all the fields, you can still add them all to What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from these last details, it seems coherent to me.
Co-authored-by: James Hemery <[email protected]>
Updated with the latest requests, thanks for reviewing 👍 |
Thank you for your contribution 🙌 |
This PR adds support for capturing the full JSON response from the autocompletion.
Useful when we don't want to type all the values in
fromValues()
.Solves #1