Newlines fix #36
Merged
Newlines fix #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is caused by newline special case CRLF being ignored by parser, when the line is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit fixes #35.
Issue is caused by fixes introduced in #31 , where I tried to fixed line numbers on Windows, but due to tests relying on .ftl files made for Linux, they weren't caught on Windows machines.
To solve #31 where a
Line\r\nI added mechanism to emit lines asLine+ MISSING_EOL flag (flag which is true forCLRFline endings). However a text like\r\nwill be treated due as `` + MISSING_EOL flag causing it to be ignored. Now these elements are no longer ignored.