Fix panic and cursor display issues for wide characters in the input field #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolved panic caused by String.insert when inserting UTF-8 characters (e.g., Korean) due to incorrect handling of char boundaries. - Added `unicode-width` dependency to properly calculate cursor position for wide characters in the terminal. - Updated cursor offset calculation to account for character width, ensuring correct cursor display for wide characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with UTF-8 handling, specifically for wide characters like Korean.
Fixes
How to test
To test this PR, you can copy and paste the following UTF-8 strings into the input field and observe the behavior.
UTF-8 Strings to test:
Steps: