Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TemporaryFolder JUnit-Test rule to create temporary directories #95

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Use TemporaryFolder JUnit-Test rule to create temporary directories #95

merged 2 commits into from
Feb 6, 2020

Conversation

macisamuele
Copy link
Collaborator

The goal of this PR is to unify the creation of temporary directories of tests under the same approach (TemporaryFolder junit rule).

cortinico
cortinico approved these changes Feb 6, 2020
View reviewed changes
Copy link
Collaborator

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortinico cortinico added this to the 1.4.0 milestone Feb 6, 2020
@macisamuele macisamuele merged commit af953eb into Yelp:master Feb 6, 2020
@macisamuele macisamuele deleted the maci-unify-temporary-directory-usage branch February 6, 2020 10:50
@cortinico cortinico added the infra PR or Issue related to project infrastructure label Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
infra PR or Issue related to project infrastructure
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@macisamuele @cortinico