Remove samples/generated-code as it is duplicated by junit-tests #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
approved these changes
Feb 3, 2020
| @@ -87,6 +85,7 @@ You can find some **examples** in this repository to help you set up your genera | |||
| * [samples/kotlin-coroutines](/samples/kotlin-coroutines)<sup>*</sup> Contains an example of an Android Library configured to output Kotlin Coroutines capable code. | |||
|
|
|||
| * [samples/junit-tests](/samples/junit-tests) This sample contains specs used to test edge cases and scenarios that have been reported in the issue tracker or that are worth testing. Tests are executed using [`moshi-codegen`](https://github.com/square/moshi#codegen). | |||
| It does also contains all the generated code inside the `/scr/main/java` folder. You can use this example to see how the generated code will _look like_ (like [here](/samples/junit-tests/src/main/java/com/yelp/codegen/generatecodesamples/apis/ResourceApi.kt)). | |||
There was a problem hiding this comment.
I think you need to add an extra space before this line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created as result of #86 conversation.
The generated-code samples are not much different than groovy-android sample except for the fact that it did contain the generated code. Unfortunately, we were not building, testing or more in general doing something with the code so it was there mostly as a sort showcase of the generator output.
As junit-tests does actually run tests on the generated code, and does include the plugin generated code we might just remove the
samples/generated-codeby hinting (on the README) the presence ofsamples/junit-testsas an example of the generated code.Additionally to that the junit-tests sample does provide a possible implementation of integration tests that allow to verify the behaviour of the APIs and Models.