Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run integration tests to improve reported coverage #85

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

macisamuele
Copy link
Collaborator

The main idea of this PR is to enhance reported coverage level.

The reasoning behind is that while running tests on travis we do actually generate samples/junit-tests and run tests on the generated code, but the execution does not actually contribute to the overall covered code.

Adding this "integration" tests like allows to actually report these covered lines as well.

You can see the report diff on https://codecov.io/gh/macisamuele/swagger-gradle-codegen/compare/9a23d299fe8a7b49e2228e3d0b2ae6a9f75da05e...8c20146919c3a1c0193ca999b18815699c0b7bc9

@macisamuele macisamuele added the infra PR or Issue related to project infrastructure label Jan 27, 2020
@macisamuele macisamuele changed the title Add tests of the Main.kt file, so coverage can reflect the real covered code Run integration tests to improve reported coverage Jan 27, 2020
Copy link
Collaborator

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@macisamuele macisamuele merged commit b81d32c into Yelp:master Jan 27, 2020
@macisamuele macisamuele deleted the maci-improve-coverage-report branch January 27, 2020 19:37
@cortinico cortinico added this to the 1.4.0 milestone Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra PR or Issue related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants