Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lint suppression directives and update jacoco version #84

Merged

Conversation

macisamuele
Copy link
Collaborator

The goal of this PR is to make Suppression of warnings/lints as selective as possible.
This is mostly done to reduce warnings reporting while interacting with the tool (at least during development) and to reduce the probability that wide scope lint ignores (ie @file:Suppress) are hiding potential new issues.

@cortinico cortinico self-requested a review January 26, 2020 23:01
@cortinico cortinico added the infra PR or Issue related to project infrastructure label Jan 26, 2020
@cortinico cortinico self-assigned this Jan 26, 2020
@cortinico cortinico added this to the 1.4.0 milestone Jan 26, 2020
Copy link
Collaborator

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change @macisamuele

and to reduce the probability that wide scope lint ignores

Those annotations are actually for Detekt. But yeah, totally agree with your argument 👍

@macisamuele macisamuele merged commit 9a23d29 into Yelp:master Jan 27, 2020
@macisamuele macisamuele deleted the maci-update-lint-suppressions-and-jacoco branch January 27, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra PR or Issue related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants