Add Gradle lazy configuration #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipemp
force-pushed
the
feature/lazy-config
branch
from
538d6e4
to
e44572d
Compare
Takes advantage of https://docs.gradle.org/current/userguide/lazy_configuration.html to instantiate configuration of the plugin's task so that when configuring the plugin it will only break if generateSwagger is run
filipemp
force-pushed
the
feature/lazy-config
branch
from
e44572d
to
6858a24
Compare
cortinico
requested changes
Sep 20, 2019
| @@ -93,14 +93,14 @@ To configure the generator, please use the `generateSwagger { }` block. Here an | |||
|
|
|||
| ```kotlin | |||
| generateSwagger { | |||
| platform = "kotlin" | |||
There was a problem hiding this comment.
Can use the Groovy DSL here?
| @@ -7,5 +7,5 @@ open class FeatureConfiguration { | |||
|
|
|||
| @Input | |||
| @Optional | |||
| var headersToRemove: Array<String> = arrayOf() | |||
| var headersToRemove: Array<String> = emptyArray() | |||
There was a problem hiding this comment.
Shouldn't this be converted to a Provider/Property as well?
| @@ -30,44 +33,51 @@ open class GenerateTask : DefaultTask() { | |||
| @Input | |||
| @Optional | |||
| @Option(option = "platform", description = "Configures the platform that is used for generating the code.") | |||
| var platform: String? = null | |||
| var platformProvider: Provider<String> = project.objects.property(String::class.javaObjectType) | |||
There was a problem hiding this comment.
Name should not be changed here as this is part of the public API (same for all of them).
| if (source != null && destin != null) { | ||
| source.copyRecursively(destin, overwrite = true) | ||
| } | ||
| } | ||
|
|
||
| private fun readVersionFromSpecfile(specFile: File) { | ||
| val swaggerSpec = SwaggerParser().readWithInfo(specFile.absolutePath, listOf(), false).swagger | ||
| specVersion = when (val version = swaggerSpec.info.version) { | ||
|
|
||
| this.specVersionProvider = when (val version = swaggerSpec.info.version) { |
There was a problem hiding this comment.
You probably don't need to re-assign this.specVersionProvider here
|
@filipemp are you still working on this ? I might pick up where you left. |
Nope, go for it |
This was referenced Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes advantage of
https://docs.gradle.org/current/userguide/lazy_configuration.html to
instantiate configuration of the plugin's task so that when configuring
the plugin it will only break if generateSwagger is run
Fixes #63