Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for moshi-codegen #68

Closed
wants to merge 1 commit into from

Conversation

filipemp
Copy link
Collaborator

Fixes #62

@filipemp filipemp self-assigned this Sep 19, 2019
@cortinico cortinico changed the title WIP Add Support for moshi-codegen Sep 20, 2019
Copy link
Collaborator

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things that are worth pointing out:

  1. The proguard configuration is definitely missing

  2. Can you try to specify a dependency on com.squareup:kotlinpoet:1.3.0. This will override the version of kotlinpoet provided by moshi

@cortinico
Copy link
Collaborator

Ping @filipemp

Moshi 1.9 was released that should fix the problems you had.

@filipemp filipemp force-pushed the feature/moshi-kotlin-codegen branch from 58e4c99 to 9033e27 Compare January 2, 2020 12:14
@filipemp
Copy link
Collaborator Author

filipemp commented Jan 2, 2020

@cortinico I just updated Moshi's version to see if it would work, locally it did. I'm not sure if we need proguard though or if not having is actually breaking the build. I'll try to get back to this over the next week or so

@cortinico
Copy link
Collaborator

Awesome :)

I'm not sure if we need proguard though or if not having is actually breaking the build

Ideally inspecting the artifact and checking if the moshi-codegen generated classes are there, should suffice.

@filipemp
Copy link
Collaborator Author

It's gonna take awhile before I can actually get back to this, if anyone else wants to pick this up, it's free. Otherwise, when I'm free again I'll work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for moshi-kotlin-codegen
2 participants