Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gradle Portal URL in settings.gradle.kts breaking Gradle syncs #59

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Fix Gradle Portal URL in settings.gradle.kts breaking Gradle syncs #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,16 @@ fun pluginIsInstalled(): Boolean {
.filterIsInstance<MavenArtifactRepository>()
.any {
try {
URL("${it.url}$path").openStream().use { stream ->
// Gradle portal is exposing a wrong URL:
// https://plugins.gradle.org/m2
// The trailing slash is missing and this is breaking
// URL composition and plugin discovery.
var baseUrlString = it.url.toString()
if (!baseUrlString.endsWith("/")) {
baseUrlString = baseUrlString.plus("/")
}
val baseUrl = URL(baseUrlString)
URL(baseUrl, path).openStream().use { stream ->
return@any stream.read() >= 0
}
} catch (ignored: java.io.IOException) {
Expand Down