Remove leading slash if Swagger Spec are specifying a basePath #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating Retrofit interfaces, we need to remove the leading slash from the generated path. Having a leading slash will force the path to be absolute for the host and will make URLs like: https://petstore.swagger.io/v2/ impossible to call. Fixes #49
Closed
|
@macisamuele What do you think about this PR? |
|
@cortinico I'll check this PR in the next days. I'm not entirely sure that the approach is fully compatible with the swagger specifications (I need to check more deeply the related issue) |
macisamuele
reviewed
Jul 25, 2019
macisamuele
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating Retrofit interfaces, we need to remove the leading
slash from the generated path. Having a leading slash will force
the path to be absolute for the host and will make URLs like:
https://petstore.swagger.io/v2/
impossible to call.
Fixes #49