Specify Java source and target compatibility version #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the directive to specify the version of Java to use to compile the Java files. Previously the version was not specified so the local JDK was used. This caused a problem with version 1.1.0 of the plugin that got compiled with Java 11 and was incompatible for users on Java 8. Fixes #38
cortinico
requested review from
markov and
raducom
and removed request for
markov
raducom
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the directive to specify the version of Java to use
to compile the Java files. Previously the version was not specified
so the local JDK was used.
This caused a problem with version 1.1.0 of the plugin that got compiled
with Java 11 and was incompatible for users on Java 8.
Fixes #38