Fix for square brackets in the operation name #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generator is broken for operations with parameters that have square brackets in the name. Apparently the version of Swagger Codegen that we're using is not excluding `[` and `]` when doing the camelization of the parameter name. Fixes #31
We need to bump the version to a -SNAPSHOT in order to be able to test the upcoming changes.
Creating the `junit-tests` sample to have a space where we can test our specs and make sure we cover all the edge cases reported in bug reports.
Travis is not able to build the project as the Gradle plugin 1.1.0-SNAPSHOT is missing in all the repository. This is preventing the project from even building the plugin and publishing it to Maven Local. To avoid this, I'm adding a conditional loading of the Gradle modules that will load the `samples` only if we the plugin is found in any repository.
macisamuele
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generator is broken for operations with parameters that have square
brackets in the name. Apparently the version of Swagger Codegen that
we're using is not excluding
[and]when doing the camelization ofthe parameter name.
Fixes #31