-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin Coroutines Support #29
Conversation
@cortinico we already discussed about the PR in person, but it would be better to keep a trace over here as well. I do like the idea of having a new "template" that allows generation of coroutine based code. What if we do have a generic The needed additions would be:
NOTE: Doing something like this will then require a major release as the original currently existing template would not be usable anymore |
After some discussion with @macisamuele we feel more comfortable pushing this to a future release |
@cortinico are you planning to release this sooner? |
I'm currently looking for feedback on this. I would be interested in understanding if you're planning to use this modified template. Regarding the timeline, ideally we can manage to have this merged and have a new release by the end of November. |
I would love to use this, but I need it ASAP. Currently I'm using Swagger Codegen which has Kotlin coroutine support already. Is there a way to generate code with this pull request? I don't know how to download entire repository, patched with a specific PR out of GitHub. Also this codegen is used through Gradle I noticed. That makes it even more difficult for me then. At least a believe so. I'm new to Android Studio, Gradle and all, sorry. Thanks |
7ec9866
to
1f15256
Compare
Hi all, please find a production-ready version of the coroutines support. Other than @macisamuele 's feedback I'd love to get an ack from either @redwarp or @filipemp. I've took a different approach from the first commit. We now don't need to clone the entire
This will be in the upcoming release @chathudan, unless we find a major blocker during the review.
@StevenKek apologize for the delay but I took a 2 months sabbatical and I haven't really checked my Github notifications :/ Ideally we're going to ship this soon and you'll have it bundled in the upcoming release.
You could checkout the fork and install the gradle plugin inside your maven local. It's doable but a bit complicated to setup. If you're not in a hurry, I advice you wait for the upcoming release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice approach to the problem.
Reduce template duplication while preserving consistency and expandability!
🚢
This is an initial PR for supporting another template to generate Kotlin-coroutines code.
I'd love to get some early feedback from @macisamuele before I continue working on this to decide how we want to setup the project.
I'm not a big fan of copying all the
.mustache
files over, so we should probably re-organize them in subfolders?What's missing:
kotlin-coroutines
to the samples