Ensure that retrofit body is not nullable #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some internal use of the plugin we did noticed that specs that allow a body parameter to be optional are converted to something similar to
@Headers( "X-Operation-ID: operation_id" ) @POST("/path") fun postBodyOptional( @retrofit2.http.Body myBodyProp: MyBodyProp? ): Single<XnullableTypeResponses>Due to some retrofit limitation/design choices it's not possible to pass
nullas body (retrofit will have issues on determining the content-type). More information are available on square/retrofit#1488There are multiple possible approaches to address this issues on the codegen and few of them require some code duplication.
The objective of this PR is just to make sure that the body will not marked as nullable, so we're basically ignoring the fact that body is an optional parameter.