-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File uploads tests #101
File uploads tests #101
Conversation
… conditions (unsafe, file, multiple-files)
@cortinico I'm going to publish a new iteration.
GitHub UI is not great for rebases (at least not in this case) 😢 |
16dbd5f
to
876bec3
Compare
samples/junit-tests/src/test/java/com/yelp/codegen/generatecodesamples/PostFileEndpointTest.kt
Outdated
Show resolved
Hide resolved
samples/junit-tests/src/test/java/com/yelp/codegen/generatecodesamples/PostFileEndpointTest.kt
Outdated
Show resolved
Hide resolved
samples/junit-tests/src/test/java/com/yelp/codegen/generatecodesamples/PostFileEndpointTest.kt
Outdated
Show resolved
Hide resolved
samples/junit-tests/src/test/java/com/yelp/codegen/generatecodesamples/PostFileEndpointTest.kt
Outdated
Show resolved
Hide resolved
samples/junit-tests/src/test/java/com/yelp/codegen/generatecodesamples/PostFileEndpointTest.kt
Outdated
Show resolved
Hide resolved
samples/junit-tests/src/test/java/com/yelp/codegen/generatecodesamples/PostFileEndpointTest.kt
Outdated
Show resolved
Hide resolved
samples/junit-tests/src/test/java/com/yelp/codegen/generatecodesamples/PostFileEndpointTest.kt
Outdated
Show resolved
Hide resolved
samples/junit-tests/src/test/java/com/yelp/codegen/generatecodesamples/PostFileEndpointTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping me be more aware of kotlin features!
Addressed the majority of comments and left few comments back
samples/junit-tests/src/test/java/com/yelp/codegen/generatecodesamples/PostFileEndpointTest.kt
Outdated
Show resolved
Hide resolved
samples/junit-tests/src/test/java/com/yelp/codegen/generatecodesamples/PostFileEndpointTest.kt
Outdated
Show resolved
Hide resolved
samples/junit-tests/src/test/java/com/yelp/codegen/generatecodesamples/PostFileEndpointTest.kt
Outdated
Show resolved
Hide resolved
samples/junit-tests/src/test/java/com/yelp/codegen/generatecodesamples/PostFileEndpointTest.kt
Outdated
Show resolved
Hide resolved
1f2d831
to
9709d55
Compare
…oach Use assert* instead of if (...) fail(...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This PR has 2 main goals
Fixes: Verify correctness of endpoints with file parameters #99
In order to be sure that the "backend" will receive valid informations I've defined a
Dispatcher
that will returns a response containing details of the body: