Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Setup is currently broken on master #58

Closed
cortinico opened this issue Aug 1, 2019 · 0 comments · Fixed by #59
Closed

Project Setup is currently broken on master #58

cortinico opened this issue Aug 1, 2019 · 0 comments · Fixed by #59
Assignees
Labels
bug Something isn't working
Milestone

Comments

@cortinico
Copy link
Collaborator

Checking out the project and opening it locally results in Gradle not properly discovering the sample projects (thanks @doug-precocity for reporting).

The issue is caused by our settings.gradle.kts file here:

return this
.pluginManagement
.repositories
.filterIsInstance<MavenArtifactRepository>()
.any {
try {
URL("${it.url}$path").openStream().use { stream ->
return@any stream.read() >= 0
}
} catch (ignored: java.io.IOException) {
return@any false
}
}

During every Gradle sync, we check if an instance of the swagger-gradle-codegen plugin is available either locally or on a remote maven repo. If the plugin is not found, the sample projects are excluded from the build (as they can't run without the gradle plugin).

Currently, the URL provided by Gradle Portal is broken (is missing a trailing slash) and this is preventing the build from finding the plugin. A workaroud is currently to install the plugin on Maven Local (./gradlew plugin:publishToMavenLocal) but we should definitely fix the script.

@cortinico cortinico added the bug Something isn't working label Aug 1, 2019
@cortinico cortinico added this to the 1.3.0 milestone Aug 1, 2019
@cortinico cortinico self-assigned this Aug 1, 2019
cortinico added a commit that referenced this issue Aug 1, 2019
I'm fixing the URL provided by the gradlePluginPortal() directive.

This is causing a failure in finding the swagger-gradle-codenge gradle
plugin and is resulting in the build not including the sample projects
during a sync.

See #58 for more context on the problems.

Fixes #58
Fixes #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant