Use wheels in non yelp env #1148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
suggested changes
Apr 18, 2017
| @@ -23,4 +23,4 @@ override_dh_auto_test: | |||
| true | |||
|
|
|||
| override_dh_virtualenv: | |||
| dh_virtualenv $EXTRA_PYPI --python=/usr/bin/python2.7 --preinstall no-manylinux1 --preinstall pip-custom-platform --pip-tool pip-custom-platform | |||
| dh_virtualenv $EXTRA_PYPI --python=/usr/bin/python2.7 --preinstall pip-custom-platform --pip-tool pip-custom-platform | |||
There was a problem hiding this comment.
you need no-manylinux1, manylinux wheels are not compatible with dh-virtualenv
this essentially defeats the purpose of this entire review :P
There was a problem hiding this comment.
Crap! why are manylinux wheels not compatible with dh-virtualenv?
You mean in some sort of technical sense, right? (not just yelp policy)
There was a problem hiding this comment.
not just yelp policy: spotify/dh-virtualenv#150
There was a problem hiding this comment.
Thank you for sharing the knowledge :)
lexman
pushed a commit
to lexman/tuttle
that referenced
this pull request
Jul 22, 2017
lexman
pushed a commit
to lexman/tuttle
that referenced
this pull request
Jul 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've were getting some Travis build failures in compiling tornado. With this change we can use wheels for that when outside of the Yelp env. This way we also don't need all the -dev packages