Apply ES5 filter fix when using test rule #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good stuff. Thanks a ton for fixing this! |
|
@kureus |
|
@Abhisar You're best asking on the elastalert gitter for help. Or if you think there is a bug open an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using elastalert-test-rule on elasticsearch v5 an error will be thrown that running your filter failed despite the test continuing to run successfully
It seems to keep backward syntax compatibility code was added to trim filters if using ES5 (bb09323) but this was only done inside the ElastAlerter class and not for MockElastAlerter. Not sure on preferred way to approach this but abstracted the code fix and used it in test_file() aswell fixing the error. Comments appreciated :-)