Skip to content

set up "trusted publishers" for releasing to npm #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
piax93 wants to merge 2 commits into from
Closed

set up "trusted publishers" for releasing to npm #358

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68c5bd1
set up "trusted publishers" for releasing to npm
piax93 Oct 20, 2025
8c586df
move permissions under publish-npm
piax93 Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
release:
types: [created]

permissions:
id-token: write # required for publishing
Copy link
Member

@kaisen kaisen Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the linked PR in the PR description, it seems that permissions should be a key under publish-npm below? i think this is better so the id-token permission is limited to only the publish step

Copy link
Author

@piax93 piax93 Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very fair point, updated


jobs:
test:
runs-on: ubuntu-22.04
Expand All @@ -27,7 +30,6 @@ jobs:
with:
node-version: 22
registry-url: https://registry.npmjs.org/
- run: npm install -g yarn@latest
- run: yarn
- run: yarn publish
env:
NODE_AUTH_TOKEN: ${{secrets.npm_token}}