Support py3 #14
Merged
Support py3 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bravado_core/docstring.py
Outdated
Contributor
There was a problem hiding this comment.
We can use six.iteritems here : https://pythonhosted.org/six/#six.iteritems
Contributor
Author
There was a problem hiding this comment.
we can, but me and spatel talked and reckoned it's not worth it. Speed and memory difference at our scales more or less negligible
Contributor
|
@benp thanks for picking this up and making it happen. lgtm |
Contributor
|
lgtm (once the jsonschema dep is ready and tests are stable) |
Contributor
Author
|
Bumped it and added a test difference for py3 for a new test : ) Should be good now methinks |
Contributor
|
lgtm apart from the |
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready once python-jsonschema/jsonschema#203 is in a release. Until then there's a bit of test flakiness for py3.
Fixes #10