Add INFORM job put, get and delete service definitions
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavanderhoorn
commented
Aug 14, 2024
gavanderhoorn
commented
Aug 14, 2024
gavanderhoorn
force-pushed
the
inform_crud
branch
2 times, most recently
from
142d1c6
to
e3d2ced
Compare
ted-miller
reviewed
Aug 16, 2024
gavanderhoorn
force-pushed
the
inform_crud
branch
from
e3d2ced
to
ed55444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: this is still a draft as we need to define proper result codes.
Not in the service defs, as we need to be able to extend them without changing the message hashes.
Opening this for visibility.
This is used for Yaskawa-Global/motoros2#278.
There are a couple of things I'm unsure about; I'll add some in-line comments.