Skip to content
This repository was archived by the owner on Aug 25, 2026. It is now read-only.

fix(kap-server): expose subagent fields in /tasks responses - #72

Merged
YaseenHQ merged 3 commits into
mainfrom
fix/upstream-batch-b
Aug 23, 2026
Merged

YaseenHQ merged 3 commits into
mainfrom
fix/upstream-batch-b

Conversation

@YaseenHQ

Copy link
Copy Markdown
Owner

Ports upstream cb30a7799 (MoonshotAI#2912): /tasks responses now carry agent_id, subagent_type and parent_tool_call_id, so a client can tell which agent a task belongs to and which tool call spawned it.

Small on its own — the more useful result is what the rest of this batch turned up. Six contested fixes were examined; two were already in our tree, applied by our own earlier work:

  • 30f56a2d2 "disable SDK-internal retries that blocked cancellation" — maxRetries: 0 is already in all three providers (our feat(tui): refresh the TUI and sync upstream correctness fixes #45), and our version is newer: it resolves auth?.baseUrl ?? this._baseUrl where upstream still reads this._baseUrl.
  • 2ee6e4312 "re-register the OAuth client when its redirect URI no longer matches" — invalidateStaleRegistration is in all four of our files (our 195f8d2b9), and ours reads await this.clientInformation() where upstream reads this.clientCache.

Both had been counted as "missing" by line-matching, because our divergence defeats exact-line comparison — exactly the failure mode that makes commit-by-commit archaeology unreliable for a fork this far along.

Also fixed a mistake of my own: merging the additive hunks dropped a registerTask line, leaving the single-task test referencing an undeclared subagentId. Caught by the suite, restored, and I stopped blind-unioning hunks after it.

Tested: full suite 17,102 passed / 0 failures; typecheck, lint, sherif, release:check and build clean.

sailist and others added 3 commits August 22, 2026 23:51
Merging the additive hunks dropped the registerTask that defines
subagentId, so the single-task test referenced an undeclared binding.
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 623176d5-a51c-43f3-9af7-963d3873db57


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@YaseenHQ
YaseenHQ merged commit cbe9115 into main Aug 23, 2026
16 checks passed
@YaseenHQ
YaseenHQ deleted the fix/upstream-batch-b branch August 23, 2026 04:03
@github-actions github-actions Bot mentioned this pull request Aug 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants