This repository was archived by the owner on Aug 25, 2026. It is now read-only.
fix(kap-server): expose subagent fields in /tasks responses - #72
Merged
Merged
Conversation
…ks responses (MoonshotAI#2912) (cherry picked from commit cb30a77)
Merging the additive hunks dropped the registerTask that defines subagentId, so the single-task test referenced an undeclared binding.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports upstream
cb30a7799(MoonshotAI#2912):/tasksresponses now carryagent_id,subagent_typeandparent_tool_call_id, so a client can tell which agent a task belongs to and which tool call spawned it.Small on its own — the more useful result is what the rest of this batch turned up. Six contested fixes were examined; two were already in our tree, applied by our own earlier work:
30f56a2d2"disable SDK-internal retries that blocked cancellation" —maxRetries: 0is already in all three providers (our feat(tui): refresh the TUI and sync upstream correctness fixes #45), and our version is newer: it resolvesauth?.baseUrl ?? this._baseUrlwhere upstream still readsthis._baseUrl.2ee6e4312"re-register the OAuth client when its redirect URI no longer matches" —invalidateStaleRegistrationis in all four of our files (our195f8d2b9), and ours readsawait this.clientInformation()where upstream readsthis.clientCache.Both had been counted as "missing" by line-matching, because our divergence defeats exact-line comparison — exactly the failure mode that makes commit-by-commit archaeology unreliable for a fork this far along.
Also fixed a mistake of my own: merging the additive hunks dropped a
registerTaskline, leaving the single-task test referencing an undeclaredsubagentId. Caught by the suite, restored, and I stopped blind-unioning hunks after it.Tested: full suite 17,102 passed / 0 failures; typecheck, lint, sherif, release:check and build clean.