Skip to content

fix(web): disable Remove while it runs, keybinding menu on Open in - #433

Merged
Yarden-zamir merged 1 commit into
mainfrom
fix/menu-review-followups
Oct 30, 2026
Merged

Yarden-zamir merged 1 commit into
mainfrom
fix/menu-review-followups

Conversation

@Yarden-zamir

Copy link
Copy Markdown
Owner

🤖 Two follow-ups from the CodeRabbit review of #431 (review 5714625530):

  • The saved-environment context menu kept "Removing…" enabled, so a right-click could start a second removal. It is now disabled while the removal runs.
  • The top-level "Open in " item showed the favorite-editor key but had no "Keybindings…" item menu or aria-keyshortcuts. It now has both.

Follow-ups from the CodeRabbit review of #431: the saved-environment object menu could start a second removal, and the top-level "Open in" item had no Keybindings item menu.
@Yarden-zamir
Yarden-zamir merged commit 4653bf2 into main Oct 30, 2026
1 check passed
@Yarden-zamir
Yarden-zamir deleted the fix/menu-review-followups branch October 30, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant