Repository navigation
fix(ci): fork release waits for a release that another platform still creates - #381
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Wait for release visibility .github/workflows/fork-release.yml |
After release creation is skipped or fails, the workflow polls gh release view. It proceeds to asset upload when the release appears, or exits with an error after the final unsuccessful check. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Merge Risk: 
Minimal · up to 3e41b
-
The release workflow now waits for release visibility before uploading assets, with a bounded failure when the release never appears.
Architecture risk: 
Low · up to 3e41b
-
The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.
Changed systems: None identified.
Architecture concerns
No architecture-level concerns identified.Review details
-
Before / after behavior
- observed — Modified behavior in .github/workflows/fork-release.yml: After release creation is skipped or fails because another platform may be creating it, the step polls
gh release viewup to 40 times, sleeping 30 seconds between checks. If the release remains unavailable on the final check, it exits with an error; otherwise, execution proceeds to asset upload.
- observed — Modified behavior in .github/workflows/fork-release.yml: After release creation is skipped or fails because another platform may be creating it, the step polls
-
Pre-merge checks: 
3 · 
1
-
Failed checks: 1 warning Passed checks: 3 passed -
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Cause
Fork Release run 40437392448 for #380 failed in "Desktop Linux arm64" at "Publish to the release" with
release not found. "Server checksums" then failed because the arm64 server archive was missing.The first platform to finish creates the release with
gh release create, and the other platforms add their files.gh release createkeeps the release a draft while it uploads its files: here from 02:15:32 to 02:22:29. A draft cannot be found by its tag. The arm64 job published inside that window:gh release viewfound nothing.gh release createfailed, because the release already existed.gh release uploadfailed withrelease not found.Fix
When
createfails, the step waits untilgh release viewfinds the release, every 30 seconds and 20 minutes at most, and then uploads. A release that never appears still fails the step.Checks
vp run fork:check: format, knip, doc links, migration check and adopted pull request check pass.Fork repair skill changes
None.