Potential fix for code scanning alert no. 25: Uncontrolled data used in path expression#1
Merged
Yardapestr merged 1 commit intomasterfrom Apr 4, 2025
Merged
Conversation
…in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Yardapemines/lightning/security/code-scanning/25
To fix the problem, we need to ensure that the constructed file path is safe and does not allow directory traversal. We can achieve this by normalizing the path and ensuring it is contained within a predefined safe directory. We will use
os.path.normpathto normalize the path and then check if the resulting path starts with the safe base directory.Suggested fixes powered by Copilot Autofix. Review carefully before merging.