test(server): validate GREMLIN Docker runtime and full stack - #200
Conversation
|
Warning Review limit reached
Next review available in: 32 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe pull request adds Docker compatibility and full-stack test paths. It updates label validation for ASCII digits, adds end-to-end smoke checks, builds isolated Docker test environments, and wires both tests into the Makefile and GitHub Actions. ChangesDocker testing
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHubActions
participant DockerStack
participant FullStackSmoke
Developer->>GitHubActions: Run Docker compatibility or full-stack job
GitHubActions->>DockerStack: Verify Docker and build test resources
DockerStack-->>GitHubActions: Start server stack
GitHubActions->>FullStackSmoke: Run authenticated smoke checks
FullStackSmoke->>DockerStack: Submit FASTA task and poll status
DockerStack-->>FullStackSmoke: Return task results and archive
FullStackSmoke-->>GitHubActions: Report validation result
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Python |  |
Jul 31, 2026 10:39a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Complexity | 1 medium |
🟢 Metrics 27 complexity · 0 duplication
Metric Results Complexity 27 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 64bac69ae4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/server-test.yml:
- Around line 84-85: Update the actions/checkout steps in both
DockerRunnerCompatibility and DockerFullStack to set persist-credentials to
false, while preserving their existing repository checkout configuration.
- Around line 75-99: Add an explicit least-privilege permissions block with
contents read access to both DockerRunnerCompatibility and DockerFullStack, at
the workflow or individual job level, without granting write access.
In `@server/tests/full_stack_smoke.py`:
- Around line 44-65: Update _wait_for_task to check response.status_code before
parsing the body, raising an AssertionError immediately for any non-200 response
with clear status and response details. Only parse JSON after confirming a 200
response, then preserve the existing finished and failed task handling while
continuing to poll valid in-progress payloads.
In `@server/tests/test_runner_docker_compat.py`:
- Around line 32-51: Add explicit timeouts to the Docker subprocess calls in the
test, including the build, image removal, and container run operations. Catch
and handle subprocess.TimeoutExpired for the docker build and run paths, while
ensuring the cleanup image-removal call remains bounded even when earlier
operations stall.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 3b5147f2-907f-49a8-ad04-8634fbf31d7f
📒 Files selected for processing (7)
.github/workflows/server-test.ymlserver/Makefileserver/scripts/gremlin_labels.pyserver/tests/full_stack_smoke.pyserver/tests/run_full_stack_test.shserver/tests/test_gremlin_labels.pyserver/tests/test_runner_docker_compat.py
1 participant
Summary
Root cause
The GREMLIN runner uses Python 3.6, while
gremlin_labels.pyused Python 3.7-only features:from __future__ import annotationsandstr.isascii(). Existing server CI ran only the Python 3.12 non-Docker suite, so runner-runtime regressions were not exercised.Validation
make -C server test— 282 passedmake -C server test-docker-compat— passed in the Python 3.6 runner imagemake -C server test-docker-full-stack— passed, including miniUC validation, API/page checks, GREMLIN task completion, result archive verification, and teardowngit diff --checkpassedSummary by CodeRabbit
Bug Fixes
Tests
Chores