Update usage recommendations (closes #26)

Yalantis · Aug 1, 2016 · 7e34a65 · 7e34a65
1 parent 5c12b17
commit 7e34a65
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 16 deletions.
diff --git a/PullToRefreshDemo/ViewController.swift b/PullToRefreshDemo/ViewController.swift
@@ -16,15 +16,13 @@ class ViewController: UIViewController {
     @IBOutlet private var tableView: UITableView!
     private var dataSourceCount = PageSize
 
-    override func viewDidAppear(animated: Bool) {
-        super.viewDidAppear(animated)
-
+    override func viewDidLoad() {
+        super.viewDidLoad()
+        
         setupPullToRefresh()
     }
 
-    override func viewDidDisappear(animated: Bool) {
-        super.viewDidDisappear(animated)
-
+    deinit {
         tableView.removePullToRefresh(tableView.bottomPullToRefresh!)
         tableView.removePullToRefresh(tableView.topPullToRefresh!)
     }
@@ -37,26 +35,20 @@ class ViewController: UIViewController {
 private extension ViewController {
 
     func setupPullToRefresh () {
-
-
         tableView.addPullToRefresh(PullToRefresh()) { [weak self] in
             let delayTime = dispatch_time(DISPATCH_TIME_NOW, Int64(2 * Double(NSEC_PER_SEC)))
             dispatch_after(delayTime, dispatch_get_main_queue()) {
-                dispatch_async(dispatch_get_main_queue()) {
-                    self?.dataSourceCount = PageSize
-                    self?.tableView.endRefreshing(at: .Top)
-                }
+                self?.dataSourceCount = PageSize
+                self?.tableView.endRefreshing(at: .Top)
             }
         }
-
+        
         tableView.addPullToRefresh(PullToRefresh(position: .Bottom)) { [weak self] in
             let delayTime = dispatch_time(DISPATCH_TIME_NOW, Int64(2 * Double(NSEC_PER_SEC)))
             dispatch_after(delayTime, dispatch_get_main_queue()) {
-                dispatch_async(dispatch_get_main_queue()) {
                 self?.dataSourceCount += PageSize
                 self?.tableView.reloadData()
                 self?.tableView.endRefreshing(at: .Bottom)
-                }
             }
         }
     }
@@ -73,4 +65,4 @@ extension ViewController:UITableViewDataSource {
         cell.textLabel?.text = "\(indexPath.row)"
         return cell
     }
-}
+}
diff --git a/README.md b/README.md
@@ -38,6 +38,15 @@ tableView.addPullToRefresh(refresher, action: {
 })
 ```
 
+⚠️ Don't forget to remove pull to refresh when your view controller is releasing. ⚠️
+
+```swift
+    deinit {
+        tableView.removePullToRefresh(tableView.topPullToRefresh!)
+    }
+```
+
+
 After the action is completed and you want to hide the refresher:
 
 ```swift