Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app.expose() with cache: true option prevents the ability to overrule it at the request level #25

Closed
caridy opened this issue Apr 3, 2014 · 2 comments · Fixed by #26
Labels

Comments

@caridy
Copy link
Contributor

caridy commented Apr 3, 2014

app.expose([1], 'app.foo', { cache: true });
res.expose([2], 'app.foo');

it will print app.foo = [1], which is incorrect.

@ericf
Copy link
Collaborator

ericf commented Apr 3, 2014

I have verified that this is a bug and occurs when the {cache: true} option is used at the app-level and the responsive-level override is the last thing to be exposed.

It seems likely to be an off-by-one type of edge case bug.

@ericf ericf added the bug label Apr 3, 2014
ericf added a commit that referenced this issue Apr 3, 2014
ericf added a commit that referenced this issue Apr 3, 2014
This improves the serialized value look-up process by checking own properties first, before walking the prototype chain to find parent values.

Fixes #25
ericf added a commit that referenced this issue Apr 3, 2014
@ericf ericf closed this as completed in #26 Apr 3, 2014
@caridy
Copy link
Contributor Author

caridy commented Apr 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants