Show creation date of comments #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrgernoe
force-pushed
the
feature/447_show-creation-date-of-comments
branch
from
43d4292 to
0855997
Compare
paetz
previously approved these changes
Jan 17, 2024
| @@ -136,10 +137,11 @@ class SectorParser(private val _db: DatabaseWrapper) : JSONWebParser() { | |||
| for (i in 0 until jsonComments.length()) { | |||
| val jsonComment = jsonComments.getJSONObject(i) | |||
| val user = jsonComment.getString("username") | |||
| val date = _parseCommentDate(jsonComment.getString("datum")) | |||
There was a problem hiding this comment.
There is also an "adatum" field which may contain the date of the latest change. Would this make more sense?
There was a problem hiding this comment.
I had a look into the PHP code of sandsteinklettern.de and for my understanding it is the archive date. It is updated, when the comment gets updated.
There was a problem hiding this comment.
I'm now prioritizing the adatum and use datum as fallback.
| * Parse comment date-times in the format yyyy-MM-dd HH:mm:ss | ||
| * and return only the date in the format yyyy-MM-dd. | ||
| */ | ||
| private fun _parseCommentDate(date: String): String = DateUtils.formatDate(date.split(" ")[0]) |
There was a problem hiding this comment.
- You should add error handling here in case
dateis an empty string.
chrgernoe
force-pushed
the
feature/447_show-creation-date-of-comments
branch
from
0855997 to
bb35a84
Compare
paetz
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #447