Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove project specific Docker environment #422

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

chrgernoe
Copy link
Member

@chrgernoe chrgernoe commented Apr 12, 2023

Since GitHub workflows/actions implementation advanced a lot since I implemented the whole Docker stuff, I decided to simply things, get rid of the project specific Docker environment and use the GitHub flow instead.

@github-actions github-actions bot added the KTLO This feature will not be delivered to customers label Apr 12, 2023
@chrgernoe chrgernoe requested a review from paetz April 12, 2023 22:46
@chrgernoe chrgernoe force-pushed the ktlo/delete-docker-environment-dependency branch from f71e1d4 to 4461333 Compare April 12, 2023 22:53
Copy link
Collaborator

@paetz paetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reducing code is always nice :)

Is CI now running unit and instrumentation tests?

@chrgernoe
Copy link
Member Author

Reducing code is always nice :)

Is CI now running unit and instrumentation tests?

Yes, the CI runs both tests but did it also before. Code coverage comes next.

@chrgernoe chrgernoe merged commit d98386e into master Apr 14, 2023
@chrgernoe chrgernoe deleted the ktlo/delete-docker-environment-dependency branch April 14, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
KTLO This feature will not be delivered to customers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants