handle buffer offset #230
Merged
handle buffer offset #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeissl
force-pushed
the
fix/buffer_offset
branch
3 times, most recently
from
895260e
to
23e46f1
Compare
|
@YaLTeR This is now just waiting for the review of Smithay/smithay#1341 |
cmeissl
force-pushed
the
fix/buffer_offset
branch
from
23e46f1
to
33e9399
Compare
cmeissl
force-pushed
the
fix/buffer_offset
branch
from
33e9399
to
d61610d
Compare
YaLTeR
reviewed
Sep 22, 2024
src/handlers/compositor.rs
Outdated
| @@ -297,13 +297,42 @@ impl CompositorHandler for State { | |||
| &self.niri.cursor_manager.cursor_image(), | |||
| CursorImageStatus::Surface(s) if s == &root_surface | |||
| ) { | |||
| with_states(surface, |states| { | |||
There was a problem hiding this comment.
Guess this should only happen if surface == root_surface
There was a problem hiding this comment.
right, while unlikely the surface could be part of a surface tree
src/handlers/compositor.rs
Outdated
| if self.niri.dnd_icon.as_ref() == Some(&root_surface) { | ||
| if matches!(&self.niri.dnd_icon, Some(icon) if icon.surface == root_surface) { | ||
| let dnd_icon = self.niri.dnd_icon.as_mut().unwrap(); | ||
| with_states(&dnd_icon.surface, |states| { |
There was a problem hiding this comment.
Guess this can only change if surface == root_surface
cmeissl
force-pushed
the
fix/buffer_offset
branch
from
d61610d
to
d6c3796
Compare
cmeissl
commented
Sep 22, 2024
src/input/mod.rs
Outdated
| @@ -2754,8 +2750,8 @@ mod tests { | |||
| // The key_code we pick is arbitrary, the only thing | |||
| // that matters is that they are different between cases. | |||
|
|
|||
| let close_key_code = close_keysym.into(); | |||
| let close_key_event = |suppr: &mut HashSet<u32>, mods: ModifiersState, pressed| { | |||
| let close_key_code = Keycode::from(close_keysym.raw() + 8u32); | |||
There was a problem hiding this comment.
Not sure about the offset here tbh
cmeissl
force-pushed
the
fix/buffer_offset
branch
from
d6c3796
to
aaad279
Compare
YaLTeR
force-pushed
the
fix/buffer_offset
branch
from
56d799b
to
42b898d
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracking of Smithay/smithay#1341